Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10016] Remove empty StringVariant.swift file #52419

Closed
benrimmington opened this issue Feb 28, 2019 · 3 comments
Closed

[SR-10016] Remove empty StringVariant.swift file #52419

benrimmington opened this issue Feb 28, 2019 · 3 comments
Assignees
Labels
improvement standard library Area: Standard library umbrella

Comments

@benrimmington
Copy link
Collaborator

Previous ID SR-10016
Radar None
Original Reporter @benrimmington
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Improvement
Assignee @milseman
Priority Medium

md5: a6e816b5835030cd55ec8dc09bd679fb

Issue Description:

StringVariant.swift was emptied as part of the "UTF-8 representation for native strings" implementation. Should the empty file be removed? (CMakeLists.txt and GroupInfo.json would also need to be updated).

@benrimmington
Copy link
Collaborator Author

Cc: @@milseman

@milseman
Copy link
Mannequin

milseman mannequin commented Feb 28, 2019

Wait, this file is still there? Yeah, we should delete it.

@milseman
Copy link
Mannequin

milseman mannequin commented Feb 28, 2019

#22984

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

1 participant