cc: @nkcsgexi @akyrtzi

I think this is the kind of contextual "classification" we have the SyntaxClassifier for.

For example for "let x: Int" "Int" is an identifier token, but the classifier will mark it as 'type-identifier'. In the case of "weak" in your example it will mark it as 'builtin-attribute' classification kind.

We already have ContextualKeyword token kind. We probably should use them for modifiers at least. WDYT @akyrtzi?

Could you clarify how we use it currently ?

In parser, we set the token kind to tok::contextual_keyword for several places such as accessor introducer (get, set, willSet, etc.), #selector, or attribute names for precedencegroup (higherThan etc.). But not for decl modifiers.

@harlanhaskins Do you remember why ContextualKeyword was introduced? It's not entirely clear from apple/swift#13321

That patch was really introducing TokenKinds to cover the new ones in apple/swift#11809

I think SyntaxClassifier serves the need that contextual_keyword served. @nkcsgexi should we get rid of contextual_keyword?

I've added a convenience API TokenSyntax.tokenClassification to get the classification for a specific token (#109 I think we should get rid of contextual_keyword.

rdar://95638944

Looks like weak in the example is now correctly classified as a contextual keyword.

~> cat /tmp/a.swift
class View {
 @IBOutlet private weak var button: UIButton!
}
~> ~/sbin/swift-frontend -frontend -emit-syntax /tmp/a.swift
…
{
    "kind": "contextual_keyword",
    "text": "weak"
},
...