[SR-10293] Fix-it for var parameter doesn't delete enough whitespace
#52693
Labels
bug
A deviation from expected or documented behavior. Also: expected but undesirable behavior.
compiler
The Swift compiler in itself
diagnostics QoI
Bug: Diagnostics Quality of Implementation
good first issue
Good for newcomers
Comments
|
Commenting here for some more visibility: The answer here is to remove this diagnostic. It no longer makes sense to go to all this trouble to maintain a fixit from Swift 2. It can be replaced by a diagnostic that detects these keywords and offers to insert backticks around them. I suspect we have machinery to do this already, so the fix might be as simple as just removing the diagnostic and shuffling the tests. |
|
Comment by Sam Lazarus (JIRA) Resolved in #24059 |
|
slazarus (JIRA User) Don't forget to mark the bug as Resolved once the PR is merged! |
|
The PR was merged a long time ago, so this should be marked as resolved I think 🙂) |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional Detail from JIRA
md5: 91a0b3c7be8151ac2b93c6b92c8bb188
Issue Description:
Consider following example:
It produces correct diagnostic `error: 'var' as a parameter attribute is not allowed` with a fix-it to remove `var` but it doesn't remove enough trailing whilespace, so the result of applying fix-it looking like this:
The text was updated successfully, but these errors were encountered: