Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10316] Generated pbxproj files should use "en" instead of "English" as "developmentRegion" #4866

Closed
swift-ci opened this issue Apr 5, 2019 · 4 comments
Closed

[SR-10316] Generated pbxproj files should use "en" instead of "English" as "developmentRegion" #4866

swift-ci opened this issue Apr 5, 2019 · 4 comments

Comments

@swift-ci
Copy link
Contributor

swift-ci commented Apr 5, 2019

Previous ID SR-10316
Radar None
Original Reporter matthew_seaman (JIRA User)
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement
Assignee matthew_seaman (JIRA)
Priority Medium

md5: d8f32274e268eb1ea0446b88c5b2a10e

Issue Description:

Fully-spelled-out language identifiers such as "English" or "French" have been unofficially-deprecated for many years, while they have been formally deprecated in Xcode 10.2 (with a warning).

Going forward, it is important that anywhere we use langauge identifiers (such as "developmentRegion" in generated pbxproj files), we use the non-legacy style. All of the still-in-use Xcode versions should be able to handle the non-legacy style just fine, though testing would be good.
@swift-ci
Copy link
Contributor Author

swift-ci commented Apr 5, 2019

Comment by Matthew Seaman (JIRA)

Assuming this is agreeable, I can take this one. It should be a one-line fix.

@ankitspd
Copy link
Member

ankitspd commented Apr 8, 2019

Sure, sounds good!

@swift-ci
Copy link
Contributor Author

swift-ci commented Apr 8, 2019

Comment by Matthew Seaman (JIRA)

#2079

@swift-ci
Copy link
Contributor Author

Comment by Matthew Seaman (JIRA)

Merged in #2079

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ankitspd @swift-ci