Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10375] Parity: Networking: URLCredential & URLCredentialStorage #3483

Closed
millenomi opened this issue Apr 9, 2019 · 3 comments
Closed

Comments

@millenomi
Copy link
Contributor

Previous ID SR-10375
Radar rdar://problem/50257772
Original Reporter @millenomi
Type Sub-task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Foundation
Labels Sub-task
Assignee None
Priority Medium

md5: ead865f4acdb90867901864585388e5c

Parent-Task:

  • SR-10347 Parity: Remove all uses of NSUnimplemented from swift-corelibs-foundation

Issue Description:

@drodriguez
Copy link
Collaborator

The NSUnimplemented calls in URLCredential are, all but one, commented out. The commented out ones are there because the missing Security.framework in other platforms (there's API using SecIdentity, SecCertificateRef, SecTrust). I don’t think those can be removed without implementing equivalents to Security.framework.

The last one I think it is a mis-implementation. It happens in the initializer, where persistence is checked not to be .persistent or .synchronizable. However, I think the check should happen when the URLCredential is added to the URLCredentialStorage, not when creating it.

The type that is completely unimplemented is URLCredentialStorage. I haven't seen a parity bug for it, but I can tackle it at least for the temporal storage. The permanent storage probably needs help for each operating system, and the synchronized storage is probably impossible in most systems. Should I assign this bug to me or create a new one for that task?

@millenomi
Copy link
Contributor Author

Partly done with: #2334

@millenomi
Copy link
Contributor Author

Done: #2421

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants