Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1046] XCTest build_script.py should use the same lit executable as Swift utils/build-script #400

Closed
modocache mannequin opened this issue Mar 24, 2016 · 1 comment

Comments

@modocache
Copy link
Mannequin

modocache mannequin commented Mar 24, 2016

Previous ID SR-1046
Radar None
Original Reporter @modocache
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s XCTest
Labels Improvement, StarterBug
Assignee nakamurafumiya003@gmail.com (JIRA)
Priority Medium

md5: ae21cddaa2a59d35e7f4efd58604c6f4

Issue Description:

swift-corelibs-xctest uses the LLVM lit test runner to compile test cases and run them. The Swift build script, utils/build-script, does the same. The Swift build script already contains logic to find a lit executable. XCTest should use the same lit executable.

XCTest's build_script.py has a "test" subcommand that takes a "--lit" path argument (added in #76 A modification should be made to the Swift build script to pass something like the following to the Linux XCTest build: https://github.com/apple/swift/blob/723559526475551de6c8211961c7f355279b85ef/utils/build-script-impl#L1763.

Here's where the Linux tests for XCTest are kicked off: https://github.com/apple/swift/blob/e8eba770d58ce512046951b0647941194987525e/utils/build-script-impl#L2203

@swift-ci
Copy link

swift-ci commented Apr 2, 2018

Comment by Fumiya Nakamura (JIRA)

Fixed apple/swift#14955

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant