Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10550] Help for -target option should say it's a triple #52950

Closed
beccadax opened this issue Apr 25, 2019 · 3 comments
Closed

[SR-10550] Help for -target option should say it's a triple #52950

beccadax opened this issue Apr 25, 2019 · 3 comments
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project

Comments

@beccadax
Copy link
Contributor

Previous ID SR-10550
Radar None
Original Reporter @beccadax
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Improvement, Driver, StarterBug
Assignee rayfix (JIRA)
Priority Medium

md5: fb5fda3df87aa3daf32dfe7cef6ee328

Issue Description:

"swift -help" shows the following output for the -target and -target-variant options:

  -target-variant <value> Generate code that may run on a particular variant of the  deployment target
  -target <value>         Generate code for the given target

This text is incredibly vague. At minimum, it should say <triple> instead of <value> to indicate that this is a target triple; it might even make sense to include an example like "x86_64-apple-macos10.9" in the description.

Command-line options and their help are specified in "include/swift/Option/Options.td". To figure out what you need to change, take a look at how some of the options which have custom names, like -sdk, are specified.
@swift-ci
Copy link
Collaborator

swift-ci commented Jun 8, 2019

Comment by Ray Fix (JIRA)

Made it say,

-target <triple> Generate code for the given target <triple>, such as x86_64-apple-macos10.9

@swift-ci
Copy link
Collaborator

swift-ci commented Jun 9, 2019

Comment by Ray Fix (JIRA)

A PR has been merged addressing this issue.

#25311

@beccadax
Copy link
Contributor Author

beccadax commented Jun 9, 2019

Resolving this since the patch has been merged to master.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler The Swift compiler in itself good first issue Good for newcomers improvement legacy driver Area → compiler: the integrated C++ legacy driver. Succeeded by the swift-driver project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beccadax @swift-ci