Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1057] build-script -x fails when compiler-rt is present #43669

Closed
swift-ci opened this issue Mar 24, 2016 · 12 comments
Closed

[SR-1057] build-script -x fails when compiler-rt is present #43669

swift-ci opened this issue Mar 24, 2016 · 12 comments
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-1057
Radar None
Original Reporter danra (JIRA User)
Type Bug
Status Resolved
Resolution Done

Attachment: Download

Environment

OS X 10.11.4, Xcode 7.3 (7D175)
Commit 9e9c80e

Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Bug, BuildScript
Assignee @vedantk
Priority Medium

md5: b700f3a237aa94f184b7d1a1ebefc425

Issue Description:

Attached output.

build-script -r -t seems to work properly.

@belkadan
Copy link
Contributor

I don't think we managed to get compiler-rt working with Xcode yet. @vedantk?

@swift-ci
Copy link
Collaborator Author

Comment by Dan Raviv (JIRA)

Just to make sure I'm clear - The issue I have is that -x doesn't work (the attached output is for -x).
I only mentioned -rt does seem to work (in case it happens to help).

@belkadan
Copy link
Contributor

Sorry, "compiler-rt" is one of the subprojects you checked out when building everything, and that's what's failing to build ("clang_rt.builtins_x86_64h_osx"). You can probably delete the "compiler-rt" folder from your top-level directory, wipe your build, and try again; it's not currently a required component.

@belkadan
Copy link
Contributor

"rt" there stands for "runtime [library]", not "-r[elease+debuginfo] -t[est]".

@swift-ci
Copy link
Collaborator Author

Comment by Dan Raviv (JIRA)

Ok, I've tried again after deleting the compiler-rt folder, but still getting some related error. Attached.
build-script-output2.txt

By the way, I've just been following the default instructions for building the project as listed in swift's main repo - seems weird that compiler-rt would be installed on OS X by these instructions if it is not supported.

@vedantk
Copy link
Member

vedantk commented Mar 24, 2016

@belkadan We haven't added support for building swift-compiler-rt with -x yet (rdar://problem/25179060).

@vedantk
Copy link
Member

vedantk commented Mar 24, 2016

danra (JIRA User) It looks like you need to remove CMakeCache and re-run cmake.

@belkadan
Copy link
Contributor

Right. It's supported on OS X, just not when building with Xcode. Since building with Xcode already doesn't do a complete build of Swift (no iOS support) we considered that acceptable for now.

Sorry, when I said "wipe your build" I meant you'll also have to delete the "build/Xcode..." directory, so that it starts from scratch.

@vedantk, should we just pass the CMake flag to disable building compiler-rt when using -x?

@vedantk
Copy link
Member

vedantk commented Mar 24, 2016

@belkadan Yes, I'll send a PR for this shortly.

@vedantk
Copy link
Member

vedantk commented Mar 24, 2016

@belkadan #1851

@swift-ci
Copy link
Collaborator Author

Comment by Dan Raviv (JIRA)

Doing a clean build after removing compiler-rt worked. Thanks!

@vedantk
Copy link
Member

vedantk commented Mar 25, 2016

We added a workaround in f9b79e4

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. build-script Area → utils: The build script
Projects
None yet
Development

No branches or pull requests

3 participants