Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10574] Update ICU on Linux to support new Japanese calendar era name #52974

Closed
swift-ci opened this issue Apr 29, 2019 · 11 comments
Closed

[SR-10574] Update ICU on Linux to support new Japanese calendar era name #52974

swift-ci opened this issue Apr 29, 2019 · 11 comments
Assignees
@spevans
Labels
improvement standard library Area: Standard library umbrella

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-10574
Radar None
Original Reporter yusukeito (JIRA User)
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure, Standard Library
Labels Improvement
Assignee @spevans
Priority Medium

md5: 74c30648d981db1f40f78a7400ef9350

Issue Description:

A new era in Japanese calendar will begin on May 1st, 2019 and the era name will be changed.

We could update ICU to support them and these versions support new era name.

2019-04-17: ICU 64.2 released. This maintenance update for ICU 64 includes draft Unicode 12.1 update, CLDR 35.1 locale data and support for new Japanese era Reiwa (令和).

2019-04-12: ICU 63.2 / 62.2 / 61.2 / 60.3 / 59.2 / 58.3 / 57.2 / 56.2 / 55.2 / 54.2 / 53.2 / 52.2 / 51.3 / 50.2 / 4.8.2 released. These maintenance updates for past ICU versions include support for new Japanese era Reiwa (令和).

In master branch of Swift, current ICU version is 61.1. So, we could update from 61.1 to 61.2.

Or ICU 64.2 is much better than minor updating since this version supports proper representation of 1st year `Gannen` (is supported on iOS and macOS as well). But I assume that more tests or validation is required for updating to this version.

I have added some tests for checking new era name on related date formatting classes and these tests should be passed after ICU is updated to newer versions.
@belkadan
Copy link
Contributor

@milseman, @millenomi, do you know how we qualify new ICUs on Linux?

@milseman
Copy link
Mannequin

milseman mannequin commented Apr 29, 2019

ianpartridge (JIRA User) might know

@swift-ci
Copy link
Collaborator Author

Comment by Ian Partridge (JIRA)

@spevans did the work to get ICU in-tree. Fixing this may be as simple as updating this line:

swift/utils/update_checkout/update-checkout-config.json

Line 71 in d044696

"icu": "release-61-1",

@spevans
Copy link
Collaborator

spevans commented Apr 30, 2019

ICU62 should work, 63 and 64 still cause some of swift-corelibs-foundation's test to fail - mostly around International Currency Symbols if I remember correctly.

ICU62 issues were fixed by apple/swift-corelibs-foundation#1736

@swift-ci
Copy link
Collaborator Author

Comment by Ian Partridge (JIRA)

@spevans is moving from 61.1 to 61.2 as simple as updating the one line in that JSON file?

@spevans
Copy link
Collaborator

spevans commented Apr 30, 2019

It should be, the buildbots do an `update-checkout` as part of the build. My only concern is that if a CI build fails and the CI emails everyone who made a change in that build, will it spam the ICU maintainers?

@swift-ci
Copy link
Collaborator Author

Comment by Ian Partridge (JIRA)

I think it should email the person who opened the PR.

Let's find out: #24387

@spevans
Copy link
Collaborator

spevans commented Apr 30, 2019

I meant the snapshot builds that run regularly. I think it emails every address it finds in the list of commits across all repos if there is a failure. I just don't know if it considers ICU to be a repo.

@spevans
Copy link
Collaborator

spevans commented Apr 30, 2019

yusukeito (JIRA User) could you please open a PR against swift-corelibs-foundation with your test cases, I'd like to see the test fail with the current ICU and then pass with the new version, thanks.

@swift-ci
Copy link
Collaborator Author

Comment by Yusuke Ito (JIRA)

Thanks for patches. I have sent additional tests for the new era. apple/swift-corelibs-foundation#2200

@spevans
Copy link
Collaborator

spevans commented Nov 20, 2019

ICU has been updated to 65.1 in master so the new calendar era name is now supported.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spevans spevans

Labels
improvement standard library Area: Standard library umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@belkadan @spevans @swift-ci