New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-1063] Have XCTestObservationCenter conform to new Swift 3 naming rules #397
Comments
Comment by Shinichi Goto (JIRA) > However, that method in Apple XCTest is now named simply shared. Where can I find this? |
|
Comment by Shinichi Goto (JIRA) Thanks and sorry for my stupid question. I was looking for only in swift repo and so I couldn't find it. |
No stupid questions--thanks for asking, and thanks for the PR!! Comment here if you find anything. |
Comment by Shinichi Goto (JIRA) Sure! |
Fixed in #82 Thanks, shingt (JIRA User)! |
Comment by Shinichi Goto (JIRA) Hi, so I've done investigation on discrepancies and found some in XCTestCase: //
// expectationWithDescription
//
// swift-corelibs-xctest
public func expectationWithDescription(description: String, file: StaticString = #file, line: UInt = #line) -> XCTestExpectation
// Apple XCTest
public func expectation(withDescription description: String) -> XCTestExpectation
//
// waitForExpectationsWithTimeout
//
// swift-corelibs-xctest
public func waitForExpectationsWithTimeout(timeout: NSTimeInterval, file: StaticString = #file, line: UInt = #line, handler: XCWaitCompletionHandler?) {
// Apple XCTest
public func waitForExpectations(withTimeout timeout: NSTimeInterval, handler: XCTest.XCWaitCompletionHandler? = nil)
//
// expectationForNotification
//
// swift-corelibs-xctest
public func expectationForNotification(notificationName: String, object objectToObserve: AnyObject?, handler: XCNotificationExpectationHandler?) -> XCTestExpectation {
// Apple XCTest
public func expectation(forNotification notificationName: String, object objectToObserve: AnyObject?, handler: XCTest.XCNotificationExpectationHandler? = nil) -> XCTestExpectation Should I make a PR? |
Comment by Shinichi Goto (JIRA) Seems #88 already solved this. |
Additional Detail from JIRA
md5: da16a265f7fa73b0cb4ebaf710ed7ada
Issue Description:
swift-corelibs-xctest's XCTestObservationCenter defines a method
sharedTestObservationCenter
. However, that method in Apple XCTest is now named simplyshared
.swift-corelibs-xctest's XCTestObservationCenter should define
shared
as well, since our goal is to have an identical API. Change the method name and update the tests.(I wonder if there are other discrepancies brought about by the Swift 3 naming rules? We should investigate.)
The text was updated successfully, but these errors were encountered: