Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10709] Swift needs allocation counter tests #53106

Open
weissi opened this issue May 17, 2019 · 2 comments
Open

[SR-10709] Swift needs allocation counter tests #53106

weissi opened this issue May 17, 2019 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella

Comments

@weissi
Copy link
Member

weissi commented May 17, 2019

Previous ID SR-10709
Radar rdar://problem/52529018
Original Reporter @weissi
Type Bug
Additional Detail from JIRA
Votes 1
Component/s Standard Library
Labels Bug
Assignee None
Priority Medium

md5: 0485647f5ac3a9e0b2ad81bf53a22c91

relates to:

  • SR-10604 dictionary modify accessor allocates every single time
  • SR-10708 switch over Dictionary lookup retains ref count
  • SR-10028 one single 'handler as? _ChannelOutboundHandler' allocates 144 times, every time it's executed
  • SR-10346 excessive reference counting, leading to CoW copy for every heap insert in NIO :|
  • SR-10682 Swift master, ARC performance regression
  • SR-11231 ManagedBufferPointer's suggested deinit allocates

Issue Description:

Frequently we see Swift regressions in allocations that get introduced in by newer Swift versions in the SwiftNIO allocation counter tests or by just manually debugging things. This is quite costly and Swift should IMHO have their own allocation counter tests that make sure allocations from certain pieces of code only ever go down.

Examples:

SwiftNIO examples:

@belkadan
Copy link
Contributor

cc @airspeedswift, @bob-wilson

@weissi
Copy link
Member Author

weissi commented Jul 2, 2019

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

2 participants