Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10804] Add $(inherited) to OTHER_SWIFT_FLAGS #4700

Closed
ankitspd opened this issue May 30, 2019 · 2 comments
Closed

[SR-10804] Add $(inherited) to OTHER_SWIFT_FLAGS #4700

ankitspd opened this issue May 30, 2019 · 2 comments
Assignees
@ankitspd
Labels
bug

Comments

@ankitspd
Copy link
Member

Previous ID SR-10804
Radar rdar://problem/50768026
Original Reporter @aciidb0mb3r
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug, StarterBug
Assignee @aciidb0mb3r
Priority Medium

md5: 97a805b3eb82159998ed8f3a2f80fee9

Issue Description:

Add `$(inherited)` to the list of `OTHER_SWIFT_FLAGS` in swift package generate-xcodeproj. At the moment if there are some other defines in `OTHER_SWIFT_FLAGS`, they are overwritten by the xcodeproj with just a `-DXcode` flag.
@belkadan
Copy link

Still working on this, drewcyborg (JIRA User)?

(I'm checking in on all the StarterBugs that haven't been touched in over a month; it's totally fine if you just haven't had time but still want to keep it.)

@ankitspd
Copy link
Member Author

#2193 master
#2194 swift-5.1-branch

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitspd ankitspd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@belkadan @ankitspd