Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10806] Implement workspace/symbol request #549

Closed
benlangmuir opened this issue May 30, 2019 · 3 comments
Closed

[SR-10806] Implement workspace/symbol request #549

benlangmuir opened this issue May 30, 2019 · 3 comments
Labels
new feature Request for a new feature

Comments

@benlangmuir
Copy link
Member

Previous ID SR-10806
Radar None
Original Reporter @benlangmuir
Type New Feature
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s SourceKit-LSP
Labels New Feature, StarterBug
Assignee literalpie (JIRA)
Priority Medium

md5: 88e6c20bbce2e4e811331802adca7a81

Issue Description:

Implement the workspace/symbol request, which given a query string returns all symbols that match.

https://microsoft.github.io/language-server-protocol/specification#workspace_symbol

To implement this, I suggest exposing the following methods from indexstore-db to the Swift wrapper code:

  • foreachSymbolName

  • foreachCanonicalSymbolOccurrenceByName

Then SourceKit-LSP can use the foreachSymbolName to get all the symbol names and perform matching against them, followed by foreachCanonicalSymbolOccurrenceByName to get the symbol information.

@swift-ci
Copy link

Comment by Ben Kindle (JIRA)

I am interested in working on this issue, but I have some questions around how to test my progress. I made a post in the swift forums but of course, help here would also be welcome.

@swift-ci
Copy link

Comment by Ben Kindle (JIRA)

I created Pull Requests 29 and 30 in indexstore-db to expose the methods required for this.
In SourceKit-LSP, PR 123 adds the functionality.

@swift-ci
Copy link

Comment by Ben Kindle (JIRA)

PR 123 was merged in August. Sorry I never closed it!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants