Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-10808] Implement textDocument/implementation request #547

Closed
benlangmuir opened this issue May 30, 2019 · 1 comment
Closed

[SR-10808] Implement textDocument/implementation request #547

benlangmuir opened this issue May 30, 2019 · 1 comment
Labels
new feature Request for a new feature

Comments

@benlangmuir
Copy link
Member

Previous ID SR-10808
Radar None
Original Reporter @benlangmuir
Type New Feature
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s SourceKit-LSP
Labels New Feature, StarterBug
Assignee cukier (JIRA)
Priority Medium

md5: 304466f6551cfc04ab251537228be24d

Issue Description:

Implement the textDocument/implementation request, which given a source location, resolves the symbol at that location, and returns the implementations of a given protocol, or protocol requirement.

https://microsoft.github.io/language-server-protocol/specification#textDocument_implementation

To implement this, you can start by looking at how jump to definition (textDocument/definition) resolves the symbol under the cursor, but instead of looking for its definition, look for all symbols that have a base relation with it (to find types that implement a protocol) or override relation (to find methods/properties that implement a protocol requirement). All of the database query methods to do this should already exist in indexstore-db's C++ code, although you may need to expose them in the Swift wrapper.

@swift-ci
Copy link

swift-ci commented Aug 4, 2019

Comment by cukr (JIRA)

Submitted at #126

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants