Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10809] Honour ClientCapabilities for code completion snippets #546

Closed
benlangmuir opened this issue May 30, 2019 · 2 comments
Closed

[SR-10809] Honour ClientCapabilities for code completion snippets #546

benlangmuir opened this issue May 30, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@benlangmuir
Copy link
Member

Previous ID SR-10809
Radar None
Original Reporter @benlangmuir
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s SourceKit-LSP
Labels Bug, StarterBug
Assignee rockbruno (JIRA)
Priority Medium

md5: 9dd1bf0b87599da59d5dbf4174138ac3

Issue Description:

We currently always return code-completion items with snippets. However, this is supposed to be configurable by the client/editor using

TextDocumentClientCapabilities
> completion
> completionItem
> snippetSupport

https://microsoft.github.io/language-server-protocol/specification#initialize

We should honour that capability, and when the editor does not support snippets, strip them out before returning the completion.
@swift-ci
Copy link

Comment by Bruno Rocha (JIRA)

Submitted at #115

@belkadan
Copy link

Since this got merged, feel free to mark it as Resolved!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@belkadan @benlangmuir @swift-ci