Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-10903] Bad diagnostic for unnamed static computed property in class #53293

Closed
hamishknight opened this issue Jun 9, 2019 · 2 comments
Closed

[SR-10903] Bad diagnostic for unnamed static computed property in class #53293

hamishknight opened this issue Jun 9, 2019 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis

Comments

@hamishknight
Copy link
Collaborator

Previous ID SR-10903
Radar None
Original Reporter @hamishknight
Type Bug
Status Closed
Resolution Done
Environment

Swift version 5.1-dev (LLVM e56fafcd29, Swift fe3ba2d77a)
Target: x86_64-apple-darwin18.5.0

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee owenvoorhees (JIRA)
Priority Medium

md5: f6faabc4f9ade31bd9680e10e5e795e6

Issue Description:

For the following code:

class C {
  static var _: Int { 0 }
}

we emit the following diagnostic (amongst others):

main.swift:178:10: error: ERROR stored properties not supported in classes; did you mean 'static'?
  static var _: Int { 0 }
  ~~~~~~ ^

It looks like while the VarDecl is being marked as being static, its pattern binding decl isn't having its static spelling kind correctly set.
@swift-ci
Copy link
Collaborator

Comment by Owen Voorhees (JIRA)

Opened a PR with a fix: #25565

@hamishknight
Copy link
Collaborator Author

Thanks Owen!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hamishknight @swift-ci