Comment by Zsolt Török (JIRA)

I really would like to tackle this down, as my first contribution. Could someone help me a bit? I think I found how to add the Fix-It, but I'm not quite sure how to position the inserted snippets. I may also have some question about testing.

Comment by Michal Cichecki (JIRA)

@harlanhaskins

Where exactly do we want to put these error messages? I was thinking about adding it to the line before function declaration:

infix operator <=> : <# Precedence Group #>
func <=> (lhs: Int, rhs: Int) -> Bool { false }

and

<# prefix or postfix #> operator <=> : <# Precedence Group #>
prefix func <=>(lhs: X) -> X {}

Comment by Zsolt Török (JIRA)

mcichecki (JIRA User)
That was exactly my first thought, but I think we also have to care about the following:

class C {
    static func <=> (lhs: C, rhs: C) -> Bool { false }
}

In this case, I think, we need to add the FixIt to the line before the class declaration instead of the line before the function declaration. Furthermore, I suppose, we need to think about nested classes too.
And this is where I got stuck with my implementation.

Comment by Michal Cichecki (JIRA)

torokzsolt (JIRA User) in this case we should also include extensions. This is example from docs.swift.org:

infix operator +-: AdditionPrecedence
extension Vector2D {
    static func +- (left: Vector2D, right: Vector2D) -> Vector2D {
        return Vector2D(x: left.x + right.x, y: left.y - right.y)
    }
} 

The only question is if that's really something that we should take care of or leave it to user who will change the position after the operator is added according to his need.

Comment by Zsolt Török (JIRA)

mcichecki (JIRA User)

You are absolutely right.
Personally, I think it would be nice if the 'fix' would not introduce a new issue to be solved. I feel that we could deal with these cases, but I don't have enough experience with the compiler to solve this problem alone.

Comment by Michal Cichecki (JIRA)

PR

This got merged, so feel free to mark it Resolved, mcichecki (JIRA User). :-) Thank you for the fix!