Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-11005] Re-enable CoreStore/Chatto after fixing ownership verification errors #53395

Closed
gottesmm opened this issue Jun 24, 2019 · 1 comment
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@gottesmm
Copy link
Member

Previous ID SR-11005
Radar None
Original Reporter @gottesmm
Type Bug
Status Closed
Resolution Invalid
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee @gottesmm
Priority Medium

md5: ae9a7c11571f440727766328fd55200e

Issue Description:

When sil-verify-all was disabled we were only verifying SIL at the beginning/end of the pipeline. This means that we were not verifying before we stripped ownership in the middle of the pipeline causing us to miss ownership verification failures in projects that are not directly managed by swift's cmake.

When I enabled this as part of my incremental enabling ownership onone everywhere, we found two ownership errors in Chatto/CoreStore. (I saw these locally and was preparing fixes for them, but thought they were triggered by my own local changes... turns out as the verifier shows the problem was on master).

@gottesmm
Copy link
Member Author

Nm. Xi reverted all of the patches. I am going to just fix it in tree.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Development

No branches or pull requests

1 participant