Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11056] SwiftPM: mirrored URLs end up in Package.resolved file #4687

Open
weissi opened this issue Jul 2, 2019 · 3 comments
Open

[SR-11056] SwiftPM: mirrored URLs end up in Package.resolved file #4687

weissi opened this issue Jul 2, 2019 · 3 comments
Assignees
@tomerd
Labels
bug

Comments

@weissi
Copy link
Member

weissi commented Jul 2, 2019

Previous ID SR-11056
Radar rdar://problem/52529014
Original Reporter @weissi
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee @tomerd
Priority Medium

md5: 703f379f20f57871ddeab6ec9096c39b

Issue Description:

Package.resolved should IMHO contain the real URLs and not the mirrored ones because through export SWIFTPM_MIRROR_CONFIG=/My/Companys/Mirror/Config/Path I can set a custom mirror configuration to make sure we never pull external dependencies.

However, the Package.resolved file should still contain the actual URLs from Package.swift or else different people will produce different Package.resolved files depending on whether they have the mirrors config installed or not.

Tested with

$ jw-swift-5.1 swift -version
Apple Swift version 5.1-dev (LLVM 2238e51577, Swift 16859f1963)
Target: x86_64-apple-darwin19.0.0
@weissi
Copy link
Member Author

weissi commented Jul 2, 2019

@swift-ci create

@weissi
Copy link
Member Author

weissi commented Apr 27, 2021

fix lives in #3447

CC @tomerd

@weissi
Copy link
Member Author

weissi commented Apr 12, 2022

@tomerd can we close this, I think this is fixed?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomerd tomerd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomerd @weissi