Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11136] Swift CI: (RxDataSources) Swift Source Compatibility Suite (master[-debug]) #53532

Closed
xedin opened this issue Jul 15, 2019 · 4 comments
Closed

[SR-11136] Swift CI: (RxDataSources) Swift Source Compatibility Suite (master[-debug]) #53532

xedin opened this issue Jul 15, 2019 · 4 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@xedin
Copy link
Member

xedin commented Jul 15, 2019

Previous ID SR-11136
Radar rdar://problem/53085707
Original Reporter @xedin
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee None
Priority Medium

md5: 29fbaf72aff04d0bcdafe9ad140a86a8

duplicates:

  • SR-11135 Swift CI: (R.swift) Swift Source Compatibility Suite (master[-debug])

is duplicated by:

  • SR-11141 [Source Compat] Possible RxSwift breakage - error: 'NSTextView' is incompatible with 'weak' references

Issue Description:

Jenkins URL: https://ci.swift.org/job/swift-master-source-compat-suite/3871

/Users/buildnode/jenkins/workspace-private/swift-master-source-compat-suite/project_cache/RxDataSources/.build/checkouts/RxSwift/Sources/RxCocoa/NSTextView+Rx.swift:20:12: error: 'NSTextView' is incompatible with 'weak' references
    public weak private(set) var textView: NSTextView?
           ^~~~~

Starting happening in build #3865 with following changes:

    AST: add a workaround for VS2017 
    Sort `DeclAttributeAndRange`s Deterministically
    AST: Remove ObjectLiteralExpr::{get,set}SemanticExpr()
    Replace all 9999 availability in non-stdlib tests. (#26109)
    Replace stdlib and test/stdlib 9999 availability. (#26108)
@beccadax
Copy link
Contributor

Likely duplicate of https://bugs.swift.org/browse/SR-11135.

@belkadan
Copy link
Contributor

The error is in fact correct, though.

@beccadax
Copy link
Contributor

SwiftPM appears to be cloning the wrong versions of dependencies. The error is correct given the version mismatch.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@justice-adams-apple
Copy link
Contributor

This issue was resolved with an update to the RxSwift revision and is no longer seen in the compat suite
https://github.com/apple/swift-source-compat-suite/pull/723/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xedin @belkadan @beccadax @justice-adams-apple