Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-11151] Rename Basic -> SPMBasic, Build -> SPMBuild, Workspace -> SPMWorkspace #4684

Open
krzyzanowskim opened this issue Jul 17, 2019 · 1 comment

Comments

@krzyzanowskim
Copy link
Contributor

Previous ID SR-11151
Radar None
Original Reporter @krzyzanowskim
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement
Assignee None
Priority Medium

md5: 0d772aa8abbe49208a7a3b43a8dd0b70

Issue Description:

Swift suppose to solve between types and modules, but it's not working very well as of today. This is why I'd love to see rename of "Workspace" and "Basic" or "SourceControl" or "Build" modules to the prefixed versions like others we already have: "SPMUtility", "SPMLibc", "SPMLLBuild".

Reasoning:
Especially "Workspace" name is easy to be a conflicting name. Consider this simple example of shadowing:

// SPM module
import Workspace

// app model
class Workspace {
}

This makes local 'Workspace' preferred when resolving and makes 'Workspace.Workspace' not accessible.

Proposed PR: #2241

@weissi
Copy link
Member

weissi commented Jun 2, 2020

@aciidb0mb3r/ @neonichu isn't this done with tools support core?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants