[SR-11170] SyntaxRewriter visitation exhausts the stack space that dispatch threads get #357
Assignees
Labels
Comments
|
The problem is that the `SyntaxRewriter` visitation exhausts the stack space that dispatch threads get. This can be reproduced from a command-line tool by doing the formatting call on a dispatch queue other than the main one. To workaround this run the formatting transformation under a pthread thread (which you can customize its stack allocation). |
|
Reproducer from a command-line tool: import Foundation
import SwiftFormat
import SwiftFormatConfiguration
import SwiftSyntax
func doit() throws {
let configuration = Configuration()
let formatter = SwiftFormatter(configuration: configuration)
let syntax = try SyntaxParser.parse(URL(fileURLWithPath: "/path/to/swift/file.swift"))
let dummyFileURL = URL(fileURLWithPath: NSTemporaryDirectory()).appendingPathComponent(UUID().uuidString + ".swift")
var output = String()
try formatter.format(syntax: syntax, assumingFileURL: dummyFileURL, to: &output)
print(output)
}
let q = DispatchQueue(label: "queue")
q.async {
try! doit()
}
sleep(1) |
|
Here's how to fix this using `Thread`: let work = DispatchWorkItem {
doFormatting()
}
let thread = Thread {
work.perform()
}
thread.stackSize = 8 << 20 // 8 MB.
thread.start()
work.wait() |
|
That did the trick! Thanks so much for the workaround, @akyrtzi - it works really nicely now. |
|
The root issue of this is being tackled in apple/swift-syntax#147 Once it‘s merged, the workaround using |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
macOS 10.14.5, Xcode 11 beta 4
Additional Detail from JIRA
md5: 1b490d131fc3f34c23c544d465e9bd6f
Issue Description:
I've been working on putting together an Xcode Source Editor Extension that will allow me to format code from within Xcode using the SwiftFormat library, however when I use essentially the same code to reformat the source as the command line `swift-format` utility, I get a crash in SwiftSyntax, as shown in the backtrace below:
I've uploaded the current state of the project to https://github.com/tonyarnold/XcodeSwiftFormatter as a reproduction of this crash.
Please let me know if you'd like more detail on anything - I'm happy to help!
The text was updated successfully, but these errors were encountered: