Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11313] run some tests in LSAN CI job #53714

Open
marcrasi mannequin opened this issue Aug 15, 2019 · 3 comments
Open

[SR-11313] run some tests in LSAN CI job #53714

marcrasi mannequin opened this issue Aug 15, 2019 · 3 comments
Assignees
@rintaro
Labels
task

Comments

@marcrasi
Copy link
Mannequin

marcrasi mannequin commented Aug 15, 2019

Previous ID SR-11313
Radar None
Original Reporter @marcrasi
Type Task
Additional Detail from JIRA
Votes 0
Component/s Project Infrastructure
Labels Task, Test
Assignee @rintaro
Priority Medium

md5: 86076117d09746fdbcb03dba784d1292

Issue Description:

The LSAN CI job currently builds the compiler and the stdlib but does not run any tests (https://github.com/apple/swift/blob/1afd0f7cf757ba6b12d2af0d151eafb022acf439/utils/build-presets.ini#L1084). This can lead to uncaught leak regressions in code paths that are not exercised by the stdlib build (e.g. SR-11287).

There seem to be enough leaks in the compiler that it would be impractical to run all tests under LSAN.

If we configure the LSAN CI job to run a whitelisted subset of tests, we could slowly add more tests to the whitelist as leaks get fixed.
@marcrasi
Copy link
Mannequin Author

marcrasi mannequin commented Aug 15, 2019

I'm not sure how to go about this. One idea would be to have an "lsan" lit feature, and add "UNSUPPORTED: lsan" to all the lit tests that we don't want to run. This would be very invasive because we'd add "UNSUPPORTED: lsan" to nearly every test at the beginning.

Is there some way to do the inverse of that? e.g. make "UNSUPPORTED: lsan" be the default, and add something like "SUPPORTED: lsan" to tests that we want to whitelist?

@rintaro
Copy link
Mannequin

rintaro mannequin commented Aug 15, 2019

@shahmishal What do you think?

@marcrasi
Copy link
Mannequin Author

marcrasi mannequin commented Sep 19, 2019

I tried out the "UNSUPPORTED: lsan" approach: #27247. It seems not too bad. There are only ~430 tests that currently need "UNSUPPORTED: lsan".

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rintaro rintaro

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants