Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-11320] Verify diagnostics mode should allow you to specify the column of a diagnostic #53721

Closed
beccadax opened this issue Aug 16, 2019 · 2 comments
Labels
compiler The Swift compiler in itself diagnostic verifier Area → compiler → Frontend: The `DiagnosticVerifier` class feature A feature request or implementation Frontend Area → compiler: Frontend

Comments

@beccadax
Copy link
Contributor

Previous ID SR-11320
Radar None
Original Reporter @beccadax
Type New Feature
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels New Feature
Assignee owenvoorhees (JIRA)
Priority Medium

md5: 02d1ee561742a233d1d549d810aa4043

Issue Description:

An expected-error, expected-warning, or expected-info comment should be able to specify a column number, perhaps using a syntax like:

// expected-error@:42 {{diagnostic message here}}

See e.g. #26544 for an example of a situation where this would be useful.

The compiler's -verify mode is implemented in lib/Frontend/DiagnosticVerifier.cpp. You'll need to parse the new information, store it, and later check it if it's been set. Make sure this feature is optional—we have a lot of tests already that don't use this, and we don't want to update all of them!

@swift-ci
Copy link
Collaborator

swift-ci commented Sep 4, 2019

Comment by Owen Voorhees (JIRA)

Added in #26997

@beccadax
Copy link
Contributor Author

beccadax commented Sep 5, 2019

Excellent—thank you!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@AnthonyLatsis AnthonyLatsis added Frontend Area → compiler: Frontend diagnostic verifier Area → compiler → Frontend: The `DiagnosticVerifier` class feature A feature request or implementation and removed new feature labels Feb 4, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler The Swift compiler in itself diagnostic verifier Area → compiler → Frontend: The `DiagnosticVerifier` class feature A feature request or implementation Frontend Area → compiler: Frontend
Projects
None yet
Development

No branches or pull requests

3 participants