Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-1142] [llbuild] Don't immediately run scanned dependencies once determined they need to run #809

Open
ddunbar opened this issue Apr 4, 2016 · 0 comments

Comments

@ddunbar
Copy link
Member

ddunbar commented Apr 4, 2016

Previous ID SR-1142
Radar rdar://problem/21793691
Original Reporter @ddunbar
Type Bug
Additional Detail from JIRA
Votes 0
Component/s llbuild
Labels Bug
Assignee None
Priority Medium

md5: 0f59127cf21fefd6bb4877a8888207a5

Issue Description:

There is a subtle bug in the current dependency scanning where we will immediately start executing a task that we have scanned and realized needs to run, but that may occur before the point at which the downstream task of which it is a dependent has actually requested it.

This generally only shows up when making us of dynamic dependencies, which is why it hasn't been noticed until now.

As a concrete example, suppose a build executes in which
C executes, computes A, realizes based on A that it needs B
so we end up with
C depends { A, B }

Now suppose that the a new build is triggered, in which the result of A differs:
C executes, computes A, realizes based on A that it needs B'

In this situation, the current dependency scanning may also traverse to B, and trigger it to rebuild even though it is not actually used.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant