Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11440] Incorrect application of function builder on call of subscript result #53841

Closed
hamishknight opened this issue Sep 10, 2019 · 1 comment
Closed

[SR-11440] Incorrect application of function builder on call of subscript result #53841

hamishknight opened this issue Sep 10, 2019 · 1 comment
Assignees
@hamishknight
Labels
accepts invalid Bug: Accepts invalid bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself type checker Area → compiler: Semantic analysis

Comments

@hamishknight
Copy link
Collaborator

Previous ID SR-11440
Radar None
Original Reporter @hamishknight
Type Bug
Status Closed
Resolution Done
Environment

Swift version 5.1-dev (LLVM c5340df2d1, Swift 6ffdccf4b4)
Target: x86_64-apple-darwin18.5.0

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, AcceptsInvalid, TypeChecker
Assignee @hamishknight
Priority Medium

md5: 62d9a4e4d19717f001e060f21a09d60a

Issue Description:

The following incorrectly compiles:

@_functionBuilder
struct TupleBuilder {
  static func buildBlock<T, U>(_ lhs: T, _ rhs: U) -> (T, U) { (lhs, rhs) }
}

struct S {
  typealias ReturnsTuple = () -> (Int, Int)
  subscript(@TupleBuilder x: ReturnsTuple) -> (ReturnsTuple) -> Void {
    return { _ in }
  }
}

let s = S()
s[{
  5
  5
}]({
  5
  5
})

However it shouldn't compile because we shouldn't be performing the function builder transform for the second closure argument passed, as this is passed to the function returned from the subscript.
@hamishknight
Copy link
Collaborator Author

Fixed by #27102

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamishknight hamishknight

Labels
accepts invalid Bug: Accepts invalid bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamishknight