Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11562] Poor diagnostics for labelling failures with key path subscripts #53967

Closed
hamishknight opened this issue Oct 2, 2019 · 1 comment
Closed

[SR-11562] Poor diagnostics for labelling failures with key path subscripts #53967

hamishknight opened this issue Oct 2, 2019 · 1 comment
Assignees
@hamishknight
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis

Comments

@hamishknight
Copy link
Collaborator

Previous ID SR-11562
Radar None
Original Reporter @hamishknight
Type Bug
Status Closed
Resolution Done
Environment

Swift version 5.1-dev (LLVM c5340df2d1, Swift 632399e)
Target: x86_64-apple-darwin18.5.0

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee @hamishknight
Priority Medium

md5: 7ad369b10b14575ec923384e1dc86504

Issue Description:

The following produce some poor diagnostics:

struct S1 {
  subscript(x x: Int) -> Int { x }
}

_ = \S1.[5] // error: '(Swift.Int) -> Swift.Int' is not convertible to '(Swift.Int) -> Swift.Int'

struct S2 {
  subscript(x x: Int) -> Int { x }
  subscript(y y: Int) -> Int { y }
}

_ = \S2.[5] // error: Type of expression is ambiguous without more context

struct S3 {
  subscript(x x: Int, y y: Int) -> Int { x }
}

_ = \S3.[y: 5, x: 5] // error: '(Swift.Int, Swift.Int) -> Swift.Int' is not convertible to '(Swift.Int, Swift.Int) -> Swift.Int'

We should be pointing out that the user is missing the argument labels for the first two cases, and the argument labels are round the wrong way for the last example.
@hamishknight
Copy link
Collaborator Author

Fixed by #27492

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamishknight hamishknight

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamishknight