[SR-11603] Compiler crash when combining property wrappers #54010
Comments
|
Reproducer that doesn't involve SwiftUI or Combine: @propertyWrapper
struct MyObservedObject<T> {
var wrappedValue: T
}
@propertyWrapper
class Wrapper<T> {
var wrappedValue: T
init(wrappedValue: T) {
self.wrappedValue = wrappedValue
}
}
struct Foo {
@MyObservedObject @Wrapper var a: Int
func bar() {
a = 1
}
} |
|
@swift-ci create |
|
@theblixguy's reproducer works for me. (Thanks, Suyash!) From messing around in the debugger, it looks like it’s trying to lower the indicated AST node into an lvalue: (accessor_decl implicit range=[suyash-repro.swift:16:34 - line:16:34] 'anonname=0x1180dbeb0' interface type='(Foo) -> (Int) -> ()' access=internal set_for=a
(parameter "self" type='Foo' interface type='Foo')
(parameter_list
(parameter "value" type='Int' interface type='Int') range=[suyash-repro.swift:16:34 - line:16:34])
(brace_stmt implicit range=[suyash-repro.swift:16:34 - line:16:34]
(assign_expr implicit type='()'
(member_ref_expr implicit type='@lvalue Int' decl=main.(file).Wrapper.wrappedValue@suyash-repro.swift:8:7 [with (substitution_map generic_signature=<T> (substitution T -> Int))]
(member_ref_expr implicit type='@lvalue Wrapper<Int>' decl=main.(file).MyObservedObject.wrappedValue@suyash-repro.swift:3:7 [with (substitution_map generic_signature=<T> (substitution T -> Wrapper<Int>))]
(member_ref_expr implicit type='@lvalue MyObservedObject<Wrapper<Int>>' decl=main.(file).Foo._a@suyash-repro.swift:16:34 direct_to_storage
==> (declref_expr implicit type='@lvalue Foo' decl=main.(file).Foo.<anonymous>.self@suyash-repro.swift:16:34 function_ref=unapplied)))) <==
(declref_expr implicit type='Int' decl=main.(file).Foo.<anonymous>.value@suyash-repro.swift:16:34 function_ref=unapplied))))If I’m reading this dump correctly, this is a nonmutating setter, so |
|
Hmm, we should already be using |
|
PR: #27727 |
|
Fixed on master. Please verify using the next development snapshot! |
|
Hi Suyash, |
AnthonyLatsis
added
the
crash
Attachment: Download
Environment
Xcode 11.1
Toolchain: Snapshot of master from Oct. 10th
Additional Detail from JIRA
md5: 1697befa2eb4165409e07f101d44070b
Issue Description:
When combining @ObservedObject property wrapper with a property wrapper of my own, the compiler crashes:
@ObservedObject @A var a: Int = 1Here is the stack trace:
Assertion failed: (address.isLValue() && "physical lvalue decl ref must evaluate to an address"), function emitUsingStorage, file /Users/buildnode/jenkins/workspace/oss-swift-package-osx/swift/lib/SILGen/SILGenLValue.cpp, line 2628.Stack dump:0. Program arguments: /Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2019-10-10-a.xctoolchain/usr/bin/swift -frontend -c /Users/mortenbekditlevsen/Desktop/Test/Test/AppDelegate.swift /Users/mortenbekditlevsen/Desktop/Test/Test/SceneDelegate.swift -primary-file /Users/mortenbekditlevsen/Desktop/Test/Test/ContentView.swift -emit-module-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView~partial.swiftmodule -emit-module-doc-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView~partial.swiftdoc -emit-module-source-info-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView~partial.swiftsourceinfo -serialize-diagnostics-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView.dia -emit-dependencies-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView.d -emit-reference-dependencies-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView.swiftdeps -target x86_64-apple-ios13.1-simulator -enable-objc-interop -sdk /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.1.sdk -I /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Products/Debug-iphonesimulator -F /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Products/Debug-iphonesimulator -enable-testing -g -module-cache-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -swift-version 5 -enforce-exclusivity=checked -Onone -D DEBUG -serialize-debugging-options -enable-anonymous-context-mangled-names -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Test-generated-files.hmap -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Test-own-target-headers.hmap -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Test-all-target-headers.hmap -Xcc -iquote -Xcc /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Test-project-headers.hmap -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Products/Debug-iphonesimulator/include -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/DerivedSources-normal/x86_64 -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/DerivedSources/x86_64 -Xcc -I/Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/DerivedSources -Xcc -DDEBUG=1 -Xcc -working-directory/Users/mortenbekditlevsen/Desktop/Test -module-name Test -o /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Build/Intermediates.noindex/Test.build/Debug-iphonesimulator/Test.build/Objects-normal/x86_64/ContentView.o -index-store-path /Users/mortenbekditlevsen/Library/Developer/Xcode/DerivedData/Test-bhccrlkgiqkpkzcabetvkbmxbfbc/Index/DataStore -index-system-modules1. Apple Swift version 5.1.1-dev (LLVM 6e04008c7f, Swift d930599394)2. While emitting SIL for setter for a (at /Users/mortenbekditlevsen/Desktop/Test/Test/ContentView.swift:23:28)3. While silgen emitFunction SIL function "@$s4Test11ContentViewV1aSivs".for setter for a (at /Users/mortenbekditlevsen/Desktop/Test/Test/ContentView.swift:23:28)0 swift 0x0000000108df92e5 llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 371 swift 0x0000000108df8595 llvm::sys::RunSignalHandlers() + 852 swift 0x0000000108df98c8 SignalHandler(int) + 2643 libsystem_platform.dylib 0x00007fff60d35b1d _sigtramp + 294 libsystem_platform.dylib 0x000000011c359268 _sigtramp + 31437761045 libsystem_c.dylib 0x00007fff60c0ba08 abort + 1206 libsystem_c.dylib 0x00007fff60c0acc2 err + 07 swift 0x0000000108f0a6e3 swift::Lowering::LValue::addNonMemberVarComponent(swift::Lowering::SILGenFunction&, swift::SILLocation, swift::VarDecl*, swift::SubstitutionMap, swift::Lowering::LValueOptions, swift::Lowering::SGFAccessKind, swift::AccessStrategy, swift::CanType) (.cold.11) + 358 swift 0x00000001055454c0 swift::Lowering::LValue::addNonMemberVarComponent(swift::Lowering::SILGenFunction&, swift::SILLocation, swift::VarDecl*, swift::SubstitutionMap, swift::Lowering::LValueOptions, swift::Lowering::SGFAccessKind, swift::AccessStrategy, swift::CanType) + 23849 swift 0x00000001055462d2 emitLValueForNonMemberVarDecl(swift::Lowering::SILGenFunction&, swift::SILLocation, swift::ConcreteDeclRef, swift::CanType, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions, swift::AccessSemantics) + 25810 swift 0x0000000105546ad7 SILGenLValue::visitDeclRefExpr(swift::DeclRefExpr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 18311 swift 0x0000000105544057 swift::ASTVisitor<SILGenLValue, swift::Lowering::LValue, void, void, void, void, void, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions>::visit(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 27912 swift 0x00000001055444be SILGenLValue::visitRec(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions, swift::Lowering::AbstractionPattern) + 20613 swift 0x0000000105547b7b SILGenLValue::visitMemberRefExpr(swift::MemberRefExpr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 92314 swift 0x0000000105544071 swift::ASTVisitor<SILGenLValue, swift::Lowering::LValue, void, void, void, void, void, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions>::visit(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 30515 swift 0x00000001055444be SILGenLValue::visitRec(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions, swift::Lowering::AbstractionPattern) + 20616 swift 0x0000000105547b7b SILGenLValue::visitMemberRefExpr(swift::MemberRefExpr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 92317 swift 0x0000000105544071 swift::ASTVisitor<SILGenLValue, swift::Lowering::LValue, void, void, void, void, void, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions>::visit(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 30518 swift 0x00000001055444be SILGenLValue::visitRec(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions, swift::Lowering::AbstractionPattern) + 20619 swift 0x0000000105547b7b SILGenLValue::visitMemberRefExpr(swift::MemberRefExpr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 92320 swift 0x0000000105544071 swift::ASTVisitor<SILGenLValue, swift::Lowering::LValue, void, void, void, void, void, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions>::visit(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 30521 swift 0x0000000105543e77 swift::Lowering::SILGenFunction::emitLValue(swift::Expr*, swift::Lowering::SGFAccessKind, swift::Lowering::LValueOptions) + 5522 swift 0x000000010552ef3b emitSimpleAssignment(swift::Lowering::SILGenFunction&, swift::SILLocation, swift::Expr*, swift::Expr*) + 93923 swift 0x0000000105520705 swift::ASTVisitor<(anonymous namespace)::RValueEmitter, swift::Lowering::RValue, void, void, void, void, void, swift::Lowering::SGFContext>::visit(swift::Expr*, swift::Lowering::SGFContext) + 1218124 swift 0x0000000105513b18 swift::Lowering::SILGenFunction::emitIgnoredExpr(swift::Expr*) + 112825 swift 0x0000000105584e93 (anonymous namespace)::StmtEmitter::visitBraceStmt(swift::BraceStmt*) + 32326 swift 0x000000010557f565 swift::Lowering::SILGenFunction::emitStmt(swift::Stmt*) + 2127 swift 0x000000010553631e swift::Lowering::SILGenFunction::emitFunction(swift::FuncDecl*) + 36628 swift 0x00000001054bb9fd swift::Lowering::SILGenModule::emitFunction(swift::FuncDecl*)::$_0::operator()(swift::SILFunction*) const + 23729 swift 0x00000001054b4183 swift::Lowering::SILGenModule::emitFunction(swift::FuncDecl*) + 61130 swift 0x000000010558d385 void llvm::function_ref<void (swift::AccessorDecl*)>::callback_fn<(anonymous namespace)::SILGenType::visitAccessors(swift::AbstractStorageDecl*)::'lambda'(swift::AccessorDecl*)>(long, swift::AccessorDecl*) + 2131 swift 0x0000000105fac405 swift::AbstractStorageDecl::visitExpectedOpaqueAccessors(llvm::function_ref<void (swift::AccessorKind)>) const + 30932 swift 0x0000000105fac275 swift::AbstractStorageDecl::visitEmittedAccessors(llvm::function_ref<void (swift::AccessorDecl*)>) const + 14933 swift 0x000000010558d208 (anonymous namespace)::SILGenType::visitVarDecl(swift::VarDecl*) + 18434 swift 0x000000010558ad2b (anonymous namespace)::SILGenType::emitType() + 37935 swift 0x000000010558aba9 swift::Lowering::SILGenModule::visitNominalTypeDecl(swift::NominalTypeDecl*) + 2536 swift 0x00000001054b90d3 swift::Lowering::SILGenModule::emitSourceFile(swift::SourceFile*) + 86737 swift 0x00000001054ba004 swift::SILModule::constructSIL(swift::ModuleDecl*, swift::Lowering::TypeConverter&, swift::SILOptions&, swift::FileUnit*) + 30838 swift 0x00000001054ba456 swift::performSILGeneration(swift::FileUnit&, swift::Lowering::TypeConverter&, swift::SILOptions&) + 3839 swift 0x00000001051c79e3 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) + 741140 swift 0x00000001051c4d86 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 304641 swift 0x000000010516a319 main + 72942 libdyld.dylib 0x00007fff60b34405 start + 143 libdyld.dylib 0x0000000000000049 start + 2672606277error: Abort trap: 6 (in target 'Test' from project 'Test')The text was updated successfully, but these errors were encountered: