Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11787] "Add explicit 'self.'" fix-it inserts in the wrong place for operator call #54197

Closed
hamishknight opened this issue Nov 15, 2019 · 1 comment
Closed

[SR-11787] "Add explicit 'self.'" fix-it inserts in the wrong place for operator call #54197

hamishknight opened this issue Nov 15, 2019 · 1 comment
Assignees
@hamishknight
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis

Comments

@hamishknight
Copy link
Collaborator

Previous ID SR-11787
Radar None
Original Reporter @hamishknight
Type Bug
Status Closed
Resolution Done
Environment

Swift version 5.1.1-dev (Swift 1e8ab6db51)
Target: x86_64-apple-darwin19.0.0

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee @hamishknight
Priority Medium

md5: c29c49fca91c86c21dbd31815da8f240

Issue Description:

For the following:

struct S {
  var x = 0
  func foo() {
    let x = 0
    x += 1
  }
}

We offer a fix-it to insert self. to refer to the property. Unfortunately this currently happens in the wrong place:

x self.+= 1
@hamishknight
Copy link
Collaborator Author

Fixed by #28288

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamishknight hamishknight

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamishknight