Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11788] "Add explicit 'self.'" fix-it should insert "Type." for a static property #54198

Closed
hamishknight opened this issue Nov 15, 2019 · 1 comment
Closed

[SR-11788] "Add explicit 'self.'" fix-it should insert "Type." for a static property #54198

hamishknight opened this issue Nov 15, 2019 · 1 comment
Assignees
@hamishknight
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis

Comments

@hamishknight
Copy link
Collaborator

Previous ID SR-11788
Radar None
Original Reporter @hamishknight
Type Bug
Status Closed
Resolution Done
Environment

Swift version 5.1.1-dev (Swift 08a27b1b54)
Target: x86_64-apple-darwin19.0.0

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee @hamishknight
Priority Medium

md5: f0f3550a71e6239fdc10a629d47d69d3

Issue Description:

For the following:

struct S {
  static var x = 0
  func foo() {
    let x = 0
    x += 1
  }
}

We incorrectly suggest adding "self." to refer to the static property. We should be suggesting "S." instead.
@hamishknight
Copy link
Collaborator Author

Fixed by #28288

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamishknight hamishknight

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamishknight