Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-11789] 'generate-xcodeproj' does not preserve quotes in '.define(...)' #4648

Closed
swift-ci opened this issue Nov 15, 2019 · 2 comments
Closed
Labels

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-11789
Radar rdar://problem/57246625
Original Reporter --marc (JIRA User)
Type Bug

Attachment: Download

Environment
  • macOS Mojave 10.14.6 (18G1012)

  • Xcode 11.2.1 (11B500)

  • Swift 5.1.2 (swiftlang-1100.0.278 clang-1100.0.33.9)

  • swift-tools-version:5.1

Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 79f46a0ff4af4cd4a402e387fc528123

Issue Description:

`generate-xcodeproj` does not preserve quotes in `.define("REALM_VERSION_STRING", to: ""(coreVersionStr)"")`.

`swift package generate-xcodeproj` is expected to preserve the expressly stated inner quotes just like `swift build` does.

Addition discussion can be found in the GitHub realm/realm-cocoa issue #6345. (realm/realm-swift#6345

Steps

1. An example project is provided as an attachment and as the GitHub repository marc-medley/RealmSPMXcode. (https://github.com/marc-medley/RealmSPMXcode)

2. Build the example project with `swift build`. The build should complete with a small number of warning not related to this issue. Observe that the quotes are preserved in the resulting `-DREALM_VERSION_STRING="5.23.6"`.

3. Create an Xcode project with `swift package generate-xcodeproj`. Build the generated Xcode project. Observe that the result does not include the express stated quotes `-DREALM_VERSION_STRING=5.23.6`.

Note that the expressly stated inner quotes are not preserved in step 3.

@beccadax
Copy link
Contributor

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
@sjavora
Copy link
Contributor

sjavora commented Jan 30, 2024

@tomerd this can be closed since generate-xcodeproj has been removed.

@tomerd tomerd closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants