Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11795] Replace OSX with macOS pretty much everywhere #54205

Open
CodaFi opened this issue Nov 17, 2019 · 5 comments · May be fixed by #70364
Open

[SR-11795] Replace OSX with macOS pretty much everywhere #54205

CodaFi opened this issue Nov 17, 2019 · 5 comments · May be fixed by #70364
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers

Comments

@CodaFi
Copy link
Member

CodaFi commented Nov 17, 2019

Previous ID SR-11795
Radar rdar://35127522
Original Reporter @CodaFi
Type Bug
Status In Progress
Resolution
Additional Detail from JIRA
Votes 1
Component/s Compiler
Labels Bug, StarterBug
Assignee Tudes100 (JIRA)
Priority Medium

md5: 01b356d7a526d3a65852312ab839b033

Issue Description:

The codebase still has quite a few places where we use the spelling OSX instead of macOS, especially in API availability stuff. While not all usages of OS X are incorrect - in particular, it is not correct to simply find-and-replace all the usages of "OS X" and "OSX" with "macOS", it's still probably a good idea to scrub the codebase of the non-essential ones. Graydon has already done most of the heavy lifting, so the end result is just responding to the feedback on #12674 rebasing it, and running the tests to verify the changes.
@beccadax
Copy link
Contributor

beccadax commented Jul 8, 2020

Tudes100 (JIRA User) Are you still working on this bug?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@Rish-it
Copy link

Rish-it commented Jan 27, 2023

@CodaFi claim

@CodaFi
Copy link
Member Author

CodaFi commented Jan 27, 2023

@Rish-it Please assign yourself to this issue - or let me know if you would like to be assigned if you cannot do so. That'll make sure you have the lock on this bug.

@tonyarnold
Copy link
Contributor

If @Rish-it isn't available to do this, I'm looking for a good starter issue — I'd be happy to rebase Graydon's work and see it through. Feel free to assign it to me 👍🏻

@Rish-it
Copy link

Rish-it commented Dec 11, 2023 via email •
edited

@tonyarnold tonyarnold linked a pull request Dec 11, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename instances of “OS X” to “macOS” tonyarnold/swift
4 participants
@tonyarnold @beccadax @CodaFi @Rish-it