New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-1187] Add example test to Dealer example #5304
Comments
I added these PR: I did not add tests to https://github.com/apple/example-package-dealer I did not test on Linux but I did add the necessary code for it to work. |
Thanks for doing this, and my apologies that I've left this so long. Max, can you please review this and accept it if appropriate? |
Anders, please review this and pull it in with any needed tweaks if appropriate. |
Reviewing. |
The tests look good in general; thanks! Just a couple of things: Thanks! |
Again, apologies that this has been sitting in limbo for a long time! |
a) b) these are meant to match the swift API naming guidelines. |
Great, thanks! I've merged these. |
Additional Detail from JIRA
md5: acc58f7cfd300680265cc96d1f2b46a7
Issue Description:
Our example packages don't currently have any tests. We should have at least one test in the package tree rooted at Dealer; preferably several. Testing is an important feature and our examples should demonstrate this.
Note: the dealer package is https://github.com/apple/example-package-dealer
The text was updated successfully, but these errors were encountered: