Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-11986] Batch mode compiles involving precompiled bridging headers revalidate PCH? #54419

Closed
DougGregor opened this issue Jan 1, 2020 · 2 comments
Closed

[SR-11986] Batch mode compiles involving precompiled bridging headers revalidate PCH? #54419

DougGregor opened this issue Jan 1, 2020 · 2 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@DougGregor
Copy link
Member

Previous ID SR-11986
Radar rdar://problem/58455465
Original Reporter @DougGregor
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee None
Priority Medium

md5: 385be80f565aedf74ea13d6753fc046c

Issue Description:

This code in the driver appears to only pass down the `-pch-disable-validation` compilation command for single-file compiles, not batch-mode compiles, meaning we're doing a lot of extra stat'ing in batch mode. We should fix that.
@beccadax
Copy link
Contributor

beccadax commented Jan 9, 2020

@swift-ci create

@DougGregor
Copy link
Member Author

#30511

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beccadax @DougGregor