New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR-12094] Swift Package Manager in 5.2 forbids previously allowed symlink directories #4617
Comments
@swift-ci create |
IIRC I did that to retain compatibility with existing behavior but maybe I misunderstood the existing behavior 🙂 I'll take a look soon. |
Thanks Ankit! |
latest snapshots still show the issue, probably need to wait one more day. Tested with
@aciidb0mb3r btw, a repro in the NIO repo is
that should only run the failing tests |
Yeah, it's in trunk snapshot but not in 5.2 yet. |
@aciidb0mb3r hmm, are you sure? I tried with
and it still fails.
|
Seems like the latest nightly on docker is not updated yet. Latest snapshot on swift.org is swift-DEVELOPMENT-SNAPSHOT-2020-01-28-a where as docker nightly currently has swift-DEVELOPMENT-SNAPSHOT-2020-01-27-a. cc @shahmishal |
The Docker image failed to update due to GPG server, I have updated the nightly dockerfiles to import the key from swift.org to avoid unexpected outage. |
Awesome![]( Thanks so much Mishal)! |
I think this can be closed, now works with both the latest 5.2 and master snapshots from docker.
|
Environment
Swift version 5.2-dev (Swift 7c021027d3)
Target: x86_64-unknown-linux-gnu
Additional Detail from JIRA
Watchers: @shahmishal
md5: 78b3b9df4e3154cc1b669c0a447ae83e
Issue Description:
In Swift versions prior to 5.2 it was acceptable to have symlinks in source directories, or even for source directories to be symlinks. These symlinks would be followed and treated as part of the directory hierarchy.
As part of the package resources work this block of code was added by @aciidb0mb3r (in this commit) that actively forbids the use of symlinks, without any justification of why they are forbidden.
This breakage caused issues in the SwiftNIO integration test suite. It's not clear that there is a good reason for forbidding the use of symlinks. If there is, we should add the missing diagnostic so others who are affected do not need to dive into the source code to find out why. If there isn't (which seems more likely to me) we should re-add the support for symlinks.
The text was updated successfully, but these errors were encountered: