We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libSwiftPM: master @ f9cf27e swift-package CLI: swift-5.2
md5: 5801698576b30e2efd92f7293bbb62db
Issue Description:
Using swift-5.2, I put a package in edit mode.
git clone git@github.com:apple/sourcekit-lsp.git git clone git@github.com:apple/indexstore-db.git cd sourcekit-lsp swift package edit IndexStoreDB --path ../indexstore-db
This creates a dependencies-state.json file that contains
"state" : { "path" : "/Users/blangmuir/src/lsp/indexstore-db", "name" : "edited" },
Now try using swiftpm from a recent master toolchain, which unexpectedly updates all the repos and takes indexstore-db out of edited state:
TOOLCHAINS="org.swift.50202001271a" swift build Updating https://github.com/apple/swift-llbuild.git Updating https://github.com/apple/swift-package-manager.git Updating https://github.com/apple/indexstore-db.git Updating https://github.com/apple/swift-tools-support-core.git Cloning https://github.com/apple/indexstore-db.git Resolving https://github.com/apple/indexstore-db.git at master Cloning https://github.com/apple/swift-package-manager.git Resolving https://github.com/apple/swift-package-manager.git at master Cloning https://github.com/apple/swift-llbuild.git Resolving https://github.com/apple/swift-llbuild.git at master Cloning https://github.com/apple/swift-tools-support-core.git Resolving https://github.com/apple/swift-tools-support-core.git at master
This removes dependencies-state.json and replaces it with workspace-state.json, and now it is no longer in edited state:
"state" : { "checkoutState" : { "branch" : "master", "revision" : "330aada8e7b815121ad838dec0a825d2a9cb5ecc", "version" : null }, "name" : "checkout" }
The text was updated successfully, but these errors were encountered:
cc @hartbit
Sorry, something went wrong.
Here is how sourcekit-lsp is setting up the Workspace in libSwiftPM in case we're holding it wrong: https://github.com/apple/sourcekit-lsp/blob/d62be20b75180cedd0e92df9f76e3d00a329cbc2/Sources/SKSwiftPMWorkspace/SwiftPMWorkspace.swift#L85
Update: I was able to reproduce from just the command-line swiftpm tools. Updated description to describe the reproduction steps.
Resolved in #2542 The issue also exists between Swift 5.1 and 5.2, so I also opened a PR against 5.2: #2543
hartbit
No branches or pull requests
Environment
libSwiftPM: master @ f9cf27e
swift-package CLI: swift-5.2
Additional Detail from JIRA
md5: 5801698576b30e2efd92f7293bbb62db
Issue Description:
Using swift-5.2, I put a package in edit mode.
git clone git@github.com:apple/sourcekit-lsp.git git clone git@github.com:apple/indexstore-db.git cd sourcekit-lsp swift package edit IndexStoreDB --path ../indexstore-db
This creates a dependencies-state.json file that contains
Now try using swiftpm from a recent master toolchain, which unexpectedly updates all the repos and takes indexstore-db out of edited state:
TOOLCHAINS="org.swift.50202001271a" swift build Updating https://github.com/apple/swift-llbuild.git Updating https://github.com/apple/swift-package-manager.git Updating https://github.com/apple/indexstore-db.git Updating https://github.com/apple/swift-tools-support-core.git Cloning https://github.com/apple/indexstore-db.git Resolving https://github.com/apple/indexstore-db.git at master Cloning https://github.com/apple/swift-package-manager.git Resolving https://github.com/apple/swift-package-manager.git at master Cloning https://github.com/apple/swift-llbuild.git Resolving https://github.com/apple/swift-llbuild.git at master Cloning https://github.com/apple/swift-tools-support-core.git Resolving https://github.com/apple/swift-tools-support-core.git at master
This removes dependencies-state.json and replaces it with workspace-state.json, and now it is no longer in edited state:
The text was updated successfully, but these errors were encountered: