Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12170] Improve SwiftPM diagnostic when a system target's module map can't be found #4607

Open
hartbit opened this issue Feb 10, 2020 · 1 comment

Comments

@hartbit
Copy link
Collaborator

hartbit commented Feb 10, 2020

Previous ID SR-12170
Radar rdar://problem/59496017
Original Reporter @hartbit
Type Improvement
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement
Assignee None
Priority Medium

md5: fc253358e271ecc097bd38fca586be84

Issue Description:

Right now, if SwiftPM doesn't find a system target's module.modulemap at the expected location, it emits the following diagnostic:

Source files for target SystemLib should be located under 'Sources/SystemLib', or a custom sources path can be set with the 'path' property in Package.swift

even if there is a module map file in that folder but with the wrong name. Perhaps SwiftPM should generate a more precise diagnostic:

missing system target module map at 'Sources/SystemLib/module.modulemap'

Or perhaps SwiftPM could also scan for any modulemap file inside the target folder.

@beccadax
Copy link
Contributor

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants