Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-12299] typo in SPM file [TSCBasic.OutputByteStream] ? #4582

Closed
swift-ci opened this issue Feb 28, 2020 · 4 comments
Closed

[SR-12299] typo in SPM file [TSCBasic.OutputByteStream] ? #4582

swift-ci opened this issue Feb 28, 2020 · 4 comments

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-12299
Radar rdar://problem/59976664
Original Reporter gavineadie (JIRA User)
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement
Assignee gavineadie (JIRA)
Priority Medium

md5: bd5546a1f28f5685b31a594aa8ba5503

Issue Description:

First time here, please excuse improper behavior.

I've just been reading SPM code and tripped over a possible documentation error. In TSCBasic.OutputByteStream.swift, lines 296-275, are there two uses of type-safe where thread-safe is intended?
@hborla
Copy link
Member

hborla commented Mar 3, 2020

@swift-ci create

@ankitspd
Copy link
Member

ankitspd commented Mar 3, 2020

Those are definitely typos! Thanks for reporting. Feel free to open a PR if you're interested 🙂

@swift-ci
Copy link
Contributor Author

swift-ci commented Mar 3, 2020

Comment by Gavin Eadie (JIRA)

PR submitted ..

@ankitspd
Copy link
Member

ankitspd commented Mar 3, 2020

#2635

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ankitspd @hborla @swift-ci