Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12351] Import errors not surfaced with incremental builds #4575

Open
swift-ci opened this issue Mar 12, 2020 · 1 comment
Open

[SR-12351] Import errors not surfaced with incremental builds #4575

swift-ci opened this issue Mar 12, 2020 · 1 comment
Labels

Comments

@swift-ci
Copy link
Contributor

Previous ID SR-12351
Radar rdar://problem/60832799
Original Reporter michellecasbon (JIRA User)
Type Bug
Environment

Ubuntu 18.04 with Swift for TensorFlow nightly build from 2020-03-11

$ swift --version
Swift version 5.2-dev (LLVM b3057cffb6, Swift 3e7cb166a6)
Target: x86_64-unknown-linux-gnu

Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 796f88aabcc747826454c1435fdc2203

Issue Description:

Incremental builds are not surfacing import errors caused by missing dependencies. This PR adds a missing dependency, but without it, `swift build` does not surface any errors.

To reproduce:

  1. Checkout the swift-models repo at this commit and run `swift build`, then `swift test`, without seeing any failures: tensorflow/swift-models@909a98e

  2. Run `rm -rf .build && swift test` to see import errors described in this PR.

  3. Run `rm -rf .build && swift build && swift test` to see the errors disappear again.

  4. Run `swift package clean && swift test` to see the errors reappear.

After adding the missing dependency (e.g. merging this PR), all of the above steps give clean builds.

@beccadax
Copy link
Contributor

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants