Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-12399] Bad diagnostic when failing to unwrap an optional #54837

Closed
hamishknight opened this issue Mar 23, 2020 · 1 comment
Closed

[SR-12399] Bad diagnostic when failing to unwrap an optional #54837

hamishknight opened this issue Mar 23, 2020 · 1 comment
Assignees
@hamishknight
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis

Comments

@hamishknight
Copy link
Collaborator

Previous ID SR-12399
Radar None
Original Reporter @hamishknight
Type Bug
Status Closed
Resolution Done
Environment

Swift version 5.3-dev (LLVM fa328ef, Swift de46690)
Target: x86_64-apple-darwin18.5.0

Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee @hamishknight
Priority Medium

md5: 893b2bc146886084679b87f760198979

Issue Description:

For the following:

func makeArray<T>(_ x: T) -> [T] { [x] }

func foo(_ x: Int?) {
  var s1116 = Set(0...10).subtracting(makeArray(x))
}

We emit the diagnostics:

main.swift:979:20: error: missing argument label '_immutableCocoaSet:' in call [missing_argument_labels]
  var s1116 = Set(0...10).subtracting(makeArray(x))
                   ^
                  _immutableCocoaSet:
main.swift:979:20: error: argument type 'ClosedRange<Int>' expected to be an instance of a class or class-constrained type [cannot_convert_argument_value_anyobject]
  var s1116 = Set(0...10).subtracting(makeArray(x))
                   ^

We should instead provide an optional unwrap diagnostic on x.
@hamishknight
Copy link
Collaborator Author

Fixed by #30686

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hamishknight hamishknight

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hamishknight