[SR-12491] Create a branch of sourcekit-lsp setup with the latest released Swift toolchain #536
Comments
|
Do we need separate branches per release, why not create a `master-with-released-swift` branch? This would be the branch that works with latest GM Xcode toolchain. Someone that wants to use latest development SKLSP with GM Xcode can use that one branch, and not have to figure out what branch they need to checkout and remember to change it when new GM comes out. |
|
I'd be fine either way. Pros for master-with-released:
Pros of master-with-swift-5.2:
Another option would be for master-with-released to be master and we have master-with-master (or some better name) for the one we build with swift master. That would further simplify things for first timers building sourcekit-lsp, but makes it a little harder to understand and work with for people who are working on the rest of the swift toolchain. |
|
@swift-ci create |
|
Since the requirement for this never really came up in the last couple of years, I’m going to close this. AFAICT the current |
Additional Detail from JIRA
md5: 7be0189d3ec7cd413edbff041349f37e
Issue Description:
It would be useful to have a branch (e.g.
master-with-swift-5.2) that contains the latest changes to sourcekit-lsp, but built to work with the currently released swift-5.2 toolchain. Currently we only have master (which works with master swift/swiftpm) and swift-5.2-branch (which works with swift-5.2, but does not receive new changes since it is already released).Specifics
Create a branch
master-with-swift-5.2that uses master sourcekit-lsp, but swiftpm from 5.2.Add PR testing for this branch that uses the latest released toolchain. This could be simpler than the existing PR testing and just use the downloadable toolchain instead of build swift from source.
Add a gated automerger from
mastertomaster-with-swift-5.2if it tests successfully.When we release swift-5.3, end support for 5.2 and move to
master-with-5.3.The text was updated successfully, but these errors were encountered: