Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-12613] Testing sourcekit-lsp with the most recent downloadable toolchain fails #4560

Closed
benlangmuir opened this issue Apr 17, 2020 · 5 comments
Closed

[SR-12613] Testing sourcekit-lsp with the most recent downloadable toolchain fails #4560

benlangmuir opened this issue Apr 17, 2020 · 5 comments
Assignees
@abertelrud
Labels
bug

Comments

@benlangmuir
Copy link
Member

Previous ID SR-12613
Radar None
Original Reporter @benlangmuir
Type Bug
Status Closed
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee @abertelrud
Priority Medium

md5: 927cd4a66e8e126a74d1880fb3d297ab

Issue Description:

We don't guarantee that testing sourcekit-lsp will always work with released toolchains, but it is really helpful if we can avoid revlock when possible. Testing sourcekit-lsp on desktop right now fails:

Test Suite 'SwiftPMIntegrationTests' started at 2020-04-16 15:22:08.485
Test Case '-[SourceKitTests.SwiftPMIntegrationTests testSwiftPMIntegration]' started.
<unknown>:0: error: -[SourceKitTests.SwiftPMIntegrationTests testSwiftPMIntegration] : failed: caught error: "The operation couldn’t be completed. (Build.BuildPlan.Error error 1.)"
Test Case '-[SourceKitTests.SwiftPMIntegrationTests testSwiftPMIntegration]' failed (0.576 seconds).
Test Suite 'SwiftPMIntegrationTests' failed at 2020-04-16 15:22:09.061.
     Executed 1 test, with 1 failure (1 unexpected) in 0.576 (0.576) seconds
Test Suite 'SwiftPMWorkspaceTests' started at 2020-04-16 15:22:09.061
Test Case '-[SKSwiftPMWorkspaceTests.SwiftPMWorkspaceTests testBasicCXXArgs]' started.
Fatal error: 'try!' expression unexpectedly raised an error: the package does not contain a buildable target: file /Users/blangmuir/src/lsp/sourcekit-lsp/Tests/SKSwiftPMWorkspaceTests/SwiftPMWorkspaceTests.swift, line 332
E[E[E[E15:22:09.57515:22:09.575[] ] Transport error: Transport error: 15:22:09.575Input/output error] 15:22:09.575
Transport error: ] Transport error: Input/output errorInput/output error

I believe this is because of #2683 (5.3: #2686
@abertelrud
Copy link
Contributor

Agreed, this is fallout from that change. Apologies, I didn't realize that different versions of libSwiftPM and PackageDescription would be used together. Ironically, Take 1 of that change would have had no such issues.

I'm working on fixing this now.

@abertelrud
Copy link
Contributor

I guess one thing of which I was unaware was that SourceKit-LSP links against libSwiftPM but can use a different PackageDescription version.

@abertelrud
Copy link
Contributor

#2696

@abertelrud
Copy link
Contributor

Fixed in 031a0f4

@benlangmuir
Copy link
Member Author

Verified after swift package update I can test sourcekit-lsp with the older toolchain. Thanks for the quick fix!

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abertelrud abertelrud

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benlangmuir @abertelrud