Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12816] SwiftPM makes excessive use of localFileSystem #4548

Open
DougGregor opened this issue May 14, 2020 · 1 comment
Open

[SR-12816] SwiftPM makes excessive use of localFileSystem #4548

DougGregor opened this issue May 14, 2020 · 1 comment
Labels

Comments

@DougGregor
Copy link
Member

Previous ID SR-12816
Radar rdar://problem/63228761
Original Reporter @DougGregor
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee None
Priority Medium

md5: 21cdaa69e8e455354383b9e23c9b8050

Issue Description:

A search in the SwiftPM code base shows that there are a significant number of references to localFileSystem (294 at the time of this writing). Outside of tests or executables, SwiftPM should be using the FileSystem instance it was provided rather than localFileSystem, the latter of which breaks the abstraction.

There are also a number of places where localFileSystem is used as a default argument. We should limit such uses to end-user-facing parts of the library, or even eliminate them entirely, because it's harder to audit callers for missing-but-intended arguments.

@DougGregor
Copy link
Member Author

@swift-cicreate

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants