Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-12842] Missing documentation for RangeExpression.~= operator #55288

Open
gwynne opened this issue May 20, 2020 · 3 comments
Open

[SR-12842] Missing documentation for RangeExpression.~= operator #55288

gwynne opened this issue May 20, 2020 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. documentation standard library Area: Standard library umbrella

Comments

@gwynne
Copy link
Contributor

gwynne commented May 20, 2020

Previous ID SR-12842
Radar rdar://problem/65491491
Original Reporter @gwynne
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, Documentation
Assignee None
Priority Medium

md5: 28e3f3762560fc35287695704135bdfd

Issue Description:

The commit 3890376 in early 2017 appears to have been partially responsible (inasmuch that it's the closest I could get to the real culprit easily, since GitHub's History and Blame interfaces don't follow file renames seemingly at all) for the accidental removal of the headerdoc comments covering the ~= operator for the various forms of Range. The missing documentation apparently went unnoticed when the operator was later reimplemented in an extension on RangeExpression. Thanks to this, there's no visible documentation for the operator's behavior at all right through to present day, at least none that I could find.

@gwynne
Copy link
Contributor Author

gwynne commented May 20, 2020

This bothered me a lot - I didn't even remember there was such an operator until I chanced on someone else's code using it in the appropriate context. IMO this says a lot about the role availability of visible documentation plays in developer awareness of functionality in the standard library. And since adding documentation comments entails very little risk of breakage, as far as I know, I think this is worth assigning a high priority. It'd be awesome if the fix could still get into Swift 5.3. I'll open a PR to add back a slightly revised version of the original documentation momentarily.

@gwynne
Copy link
Contributor Author

gwynne commented May 20, 2020

#31907 (master)
#31908 (5.3)

@airspeedswift
Copy link
Member

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. documentation standard library Area: Standard library umbrella
Projects
None yet
Development

No branches or pull requests

2 participants