Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-12946] Cast warning shows when checking type #55392

Closed
swift-ci opened this issue Jun 7, 2020 · 3 comments
Closed

[SR-12946] Cast warning shows when checking type #55392

swift-ci opened this issue Jun 7, 2020 · 3 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation standard library Area: Standard library umbrella type checker Area → compiler: Semantic analysis

Comments

@swift-ci
Copy link
Collaborator

swift-ci commented Jun 7, 2020

Previous ID SR-12946
Radar None
Original Reporter eunji (JIRA User)
Type Bug
Status Resolved
Resolution Done

Attachment: Download

Environment

macOS Catalina 10.15.3

Additional Detail from JIRA
Votes 0
Component/s Compiler, Standard Library
Labels Bug, DiagnosticsQoI, TypeChecker
Assignee None
Priority Medium

md5: be86f1fa5faeadff4a24489b5ec66f16

Issue Description:

While building swift/stdlib/public/core I see warning in the build in ArrayBuffer.swift.

Warning is weird since `is` is not casting, it's type checking.

So I tried on the playground and same thing happened.

Type checking returns correct value though, it shows casting warning.

Isn't this a bug? Am I understanding right?
@LucianoPAlmeida
Copy link
Collaborator

Not really sure, but seems like this problem is related to the type checker trying to diagnose a * is* check that will be done in runtime. Right CodaFi (JIRA User)?

@LucianoPAlmeida
Copy link
Collaborator

Here is a PR #32234

@LucianoPAlmeida
Copy link
Collaborator

Fixed on master, eunji (JIRA User) Could you please verify and close this on the next available snapshot 🙂 Thanks

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself diagnostics QoI Bug: Diagnostics Quality of Implementation standard library Area: Standard library umbrella type checker Area → compiler: Semantic analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucianoPAlmeida @swift-ci