Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13144] Check if cmake/modules/DarwinSDKs.cmake should contain arm64 on line 33 #55591

Closed
shahmishal opened this issue Jul 5, 2020 · 1 comment
Assignees
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself

Comments

@shahmishal
Copy link
Member

Previous ID SR-13144
Radar None
Original Reporter @shahmishal
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug
Assignee @dcci
Priority Medium

Watchers: @shahmishal

md5: d67e66745ef5ae6dab09e288588a2f43

Issue Description:

cltnschlosser asked if we need to add arm64 to line 33 in cmake/modules/DarwinSDKs.cmake.

cltnschlosser:
Should this include arm64 like line 17?

https://github.com/apple/swift/pull/32705/files/899925add32444966ec0b2c408716de743072240#r449779222

Pull request – #32705

set(SUPPORTED_OSX_ARCHS "x86_64;arm64e")
if (${SWIFT_OSX_SDK_VERSION} STREQUAL "10.14" OR
     ${SWIFT_OSX_SDK_VERSION} STREQUAL "10.15")
   set(SUPPORTED_OSX_ARCHS "x86_64")
 else()
   set(SUPPORTED_OSX_ARCHS "x86_64;arm64e")
@dcci
Copy link
Mannequin

dcci mannequin commented Jul 6, 2020

Should be fixed by:
#32722

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. compiler The Swift compiler in itself
Projects
None yet
Development

No branches or pull requests

1 participant