Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13266] SwiftPM's ModuleMapGenerator should use DiagnosticsEngine #4520

Closed
abertelrud opened this issue Jul 21, 2020 · 2 comments
Closed
Assignees
Labels

Comments

@abertelrud
Copy link
Contributor

Previous ID SR-13266
Radar rdar://problem/65891271
Original Reporter @abertelrud
Type Bug
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Bug
Assignee @abertelrud
Priority Medium

md5: 72794576836e121980587c01bc57587f

is duplicated by:

  • SR-13265 SwiftPM ModuleMapGenerator should use DiagnosticsEngine

Issue Description:

SwiftPM's ModuleMapGenerator currently emits any warnings to `stdout` and throws specialized errors in case of problems. It should use DiagnosticsEngine like the rest of SwiftPM.

The output to `stdout` is particularly problematic since it can interfere with things like `swift package describe --type json` (which, by the way, is somewhat fragile already, since any `stdout` output can interfere with it — better to provide a way to emit the JSON to a pipe or file, but that's a separate JIRA).

@abertelrud
Copy link
Contributor Author

@swift-ci create

@abertelrud
Copy link
Contributor Author

This was fixed in 933c5d70c1cba4d096953769466cd3056f39ca03

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant