Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13506] [AD] Use principled mangling for AD-generated symbols #52204

Closed
rxwei opened this issue Jan 28, 2019 · 2 comments
Closed

[SR-13506] [AD] Use principled mangling for AD-generated symbols #52204

rxwei opened this issue Jan 28, 2019 · 2 comments
Assignees
@rxwei
Labels
AutoDiff compiler The Swift compiler in itself task

Comments

@rxwei
Copy link
Member

rxwei commented Jan 28, 2019

Previous ID SR-13506
Radar rdar://problem/68381012
Original Reporter @rxwei
Type Task
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Task, AutoDiff
Assignee @rxwei
Priority Medium

md5: 5da9171ed94a34d266736c14fc16e0c0

Sub-Tasks:

  • SR-13507 Implement demangling/remangling for AutoDiff generated functions
  • SR-13508 Mangle AD thunks
  • SR-13509 Mangle derivative generic signature requirements for derivative functions
  • SR-13510 Use ASTMangler for AD-generated autodiff associated functions
  • SR-13511 Mangle AutoDiff-generated structs and enums

is duplicated by:

  • TF-627 [AD] Implement robust mangling scheme for derivative functions

relates to:

  • TF-482 [AD] Change logic for "generic requirements are not met" error

Issue Description:

So far, ad-hoc mangling has been used for AD-generated symbols:

  • JVP/VJP/differential/pullback functions.

  • Differentiability witnesses.

  • Various thunks (self-reordering during SILGen, index subset during AD transform, reabstraction thunks).

We should switch to the existing mangling system (mangler, demangler, remangler). This will make it easier to debug/understand SIL.
@dan-zheng
Copy link
Collaborator

Note: robust mangling for autodiff-generated functions (TF-679) was essentially done in #26624, but had to be reverted due to an unhandled edge case: autodiff function mangling + generic specialization mangling.

#26624 remains a good starting point for picking up this work again.

@rxwei
Copy link
Member Author

rxwei commented Sep 5, 2020

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rxwei rxwei

Labels
AutoDiff compiler The Swift compiler in itself task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rxwei @dan-zheng