Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-13594] report terminal as a tty if under ConPty #4496

Closed
compnerd opened this issue Sep 24, 2020 · 3 comments
Closed

[SR-13594] report terminal as a tty if under ConPty #4496

compnerd opened this issue Sep 24, 2020 · 3 comments
Assignees
@compnerd
Labels
windows

Comments

@compnerd
Copy link
Collaborator

Previous ID SR-13594
Radar None
Original Reporter @compnerd
Type Improvement
Status Resolved
Resolution Done
Additional Detail from JIRA
Votes 0
Component/s Package Manager
Labels Improvement, StarterBug, Windows
Assignee @compnerd
Priority Medium

md5: 29d792b132138ce620d7de1cae69487a

Issue Description:

We should report a property tty when running under ConPty and not being redirected. Currently we always report a dumb terminal to ensure compatibility with the old windows console.
@compnerd
Copy link
Collaborator Author

CC: @abertelrud

@compnerd
Copy link
Collaborator Author

compnerd commented Mar 4, 2022

Build: adjust the BuildSystemDelegate hander by compnerd · Pull Request #4192 · apple/swift-package-manager (github.com)

That change is the key for supporting the pretty printing support in SPM on Windows. With that, I am able to get nice diagnostics from the C/C++ and Swift compilers and retain the pretty printing.

@compnerd
Copy link
Collaborator Author

compnerd commented Mar 4, 2022

TSCBasic: enable proper rendering on Windows by compnerd · Pull Request #294 · apple/swift-tools-support-core (github.com)

Restores the normal behaviour in TSC for the progress reporting on Windows. This seems to be working well locally.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 4, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compnerd compnerd

Labels
windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@compnerd