Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-1365] Use proper names for Android NDK and SDK locations #43974

Open
swift-ci opened this issue Apr 29, 2016 · 1 comment
Open

[SR-1365] Use proper names for Android NDK and SDK locations #43974

swift-ci opened this issue Apr 29, 2016 · 1 comment
Labels
Android Platform: Android bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. good first issue Good for newcomers

Comments

@swift-ci
Copy link
Collaborator

Previous ID SR-1365
Radar None
Original Reporter ewmailing (JIRA User)
Type Bug
Additional Detail from JIRA
Votes 0
Component/s
Labels Bug, Android, StarterBug
Assignee None
Priority Medium

md5: 7e49de116e0b50836f6d239adca7376b

Issue Description:

This bug may already be out of date as it looked like ANDROID_NDK_HOME was being phased out, but I wanted to point this out because it looks like it still exists in the code base and I believe the variable is wrong.

If anything, it should be ANDROID_NDK_ROOT, not ANDROID_NDK_HOME. Last time I pinned the Android folks down on these, they didn’t want to say any of these were official, but this is the explanation:

This was from David Turner from the Android team:
[quote]

ANDROID_NDK_ROOT -> installation dir of NDK
ANDROID_SDK_ROOT -> installation dir of SDK
ANDROID_SDK_HOME -> location of SDK-related user files, defaults to
~/.android/ on Unix.

These variables are essentially used by the platform and SDK tools
themselves, so are your best bet.

There is no ANDROID_NDK_HOME.

They are also used by the Chromium build for Android.
[/quote]

If Swift is going to continue using a variable, ANDROID_NDK_HOME should be changed to ANDROID_NDK_ROOT.
@modocache
Copy link
Mannequin

modocache mannequin commented Jun 6, 2016

Thanks for bringing this up, ewmailing (JIRA User), and sorry for the slow response! Yup, as you mentioned, we no longer use ANDROID_NDK_HOME. However, the following CMake variables do exist:

  • SWIFT_ANDROID_NDK_PATH

  • SWIFT_ANDROID_SDK_PATH

Do you think we should change these?

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android Platform: Android bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swift-ci